Skip to content

fix: duplicated "on" in cookiejar.py comment#12534

Open
otjdiepluong wants to merge 1 commit into
aio-libs:masterfrom
otjdiepluong:fix/duplicated-on-in-cookiejar-comment
Open

fix: duplicated "on" in cookiejar.py comment#12534
otjdiepluong wants to merge 1 commit into
aio-libs:masterfrom
otjdiepluong:fix/duplicated-on-in-cookiejar-comment

Conversation

@otjdiepluong
Copy link
Copy Markdown

One-line typo fix in aiohttp/cookiejar.py: "# cookies set on on filtered are fully constructed" → "# cookies set on filtered are fully constructed". No code/behavior change.

Signed-off-by: Maya Chen <275405107+otjdiepluong@users.noreply.github.com>
@otjdiepluong otjdiepluong requested a review from asvetlov as a code owner May 14, 2026 05:43
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will improve performance by 8.77%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 71 untouched benchmarks
⏩ 69 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
test_client_send_large_websocket_compressed_messages[zlib_ng.zlib_ng] 30 ms 27.5 ms +8.77%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing otjdiepluong:fix/duplicated-on-in-cookiejar-comment (52b7d26) with master (7eb0e80)

Open in CodSpeed

Footnotes

  1. 69 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.94%. Comparing base (7eb0e80) to head (52b7d26).
⚠️ Report is 45 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12534   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         131      131           
  Lines       46622    46622           
  Branches     2414     2414           
=======================================
  Hits        46132    46132           
  Misses        367      367           
  Partials      123      123           
Flag Coverage Δ
Autobahn 22.44% <ø> (ø)
CI-GHA 98.91% <ø> (ø)
OS-Linux 98.66% <ø> (ø)
OS-Windows 97.03% <ø> (ø)
OS-macOS 97.93% <ø> (-0.01%) ⬇️
Py-3.10.11 97.42% <ø> (-0.01%) ⬇️
Py-3.10.20 97.91% <ø> (ø)
Py-3.11.15 98.16% <ø> (ø)
Py-3.11.9 97.68% <ø> (+<0.01%) ⬆️
Py-3.12.10 97.76% <ø> (ø)
Py-3.12.13 98.25% <ø> (ø)
Py-3.13.13 98.47% <ø> (ø)
Py-3.14.4 97.70% <ø> (-0.74%) ⬇️
Py-3.14.5 98.20% <ø> (?)
Py-3.14.5t 97.54% <ø> (+<0.01%) ⬆️
Py-pypy3.11.15-7.3.21 ?
Py-pypy3.11.15-7.3.22 97.41% <ø> (?)
VM-macos 97.93% <ø> (-0.01%) ⬇️
VM-ubuntu 98.66% <ø> (ø)
VM-windows 97.03% <ø> (ø)
cython-coverage 37.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant